Creating PRs for code review

Within DM, we commonly use GitHub pull requests for performing code reviews. Many of us — particularly, I suspect, those who have been with the project for some time — are pretty lax about who actually creates the PR: sometimes it’s the author of the code, and sometimes it’s the reviewer.

GitHub recently overhauled the way that review by pull request works. @kfindeisen discovered that it’s not possible to fully take advantage of this new scheme unless the author (not the reviewer) is the one who creates the PR.

This is already consistent with our documented workflow, but, since it’s not always what happens in practice, I thought a reminder was appropriate.

(By the way, note that although the new GitHub system makes it possible to mark a pull request as “approved”, our workflow does not regard the code as having been properly reviewed until the JIRA ticket is marked as such.)